[reproducer] Add virthost DNS record #3482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-metal3/dev-scripts writes an entry for virthost in /etc/hosts, but the dnsmasq server created by libvirt-manager does not read /etc/hosts. Add virthost.<cluster>.<domain> to the utility DNS host record to support devscripts local registry mirror when mirror_images is enabled. Signed-off-by: Harald Jensås <[email protected]>
hjensas
force-pushed
the
virthost-dns-record
branch
from
92df7fb to
c661fbd
Compare
hjensas
changed the title
rebtoor
approved these changes
Nov 13, 2025
Contributor
|
/lgtm |
Contributor
|
/lgtm |
michburk
approved these changes
Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift-metal3/dev-scripts writes an entry for virthost in /etc/hosts, but the dnsmasq server created by libvirt-manager does not read /etc/hosts.
Add virthost.. to the utility DNS host record to support devscripts local registry mirror when mirror_images is enabled.